Conversation
It required RBTree to perform decently and the external dependency was not suitable for a standard library. The pure ruby fallback implementation was originally meant to be an example of how to write a subclass of Set, and its poor performance was not suitable for use in production. I decided it should be distributed as an external library instead of bundling it with Set.
Member
|
I completely agree, and it's performance is not great. |
Member
|
I don't know if these are used much or at all (I notice that there's a typo in the class |
Member
Author
|
Just pushed sorted_set 1.0.0: https://rubygems.org/gems/sorted_set |
alissa-huskey
added a commit
to alissa-huskey/skippy
that referenced
this pull request
Aug 6, 2022
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
alissa-huskey
added a commit
to alissa-huskey/skippy
that referenced
this pull request
Aug 6, 2022
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
alissa-huskey
added a commit
to alissa-huskey/skippy
that referenced
this pull request
Aug 6, 2022
Add sorted_set gem to Gemfile SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
alissa-huskey
added a commit
to alissa-huskey/skippy
that referenced
this pull request
Aug 6, 2022
Add sorted_set gem to Gemfile SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
alissa-huskey
added a commit
to alissa-huskey/skippy
that referenced
this pull request
Aug 6, 2022
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
31 tasks
This was referenced Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It required RBTree to perform decently and the external dependency was not suitable for a standard library. The pure ruby fallback implementation was originally meant to be a demonstration of how to write a subclass of Set, and its poor performance was not suitable for use in production.
I decided it should be distributed as an external library instead of bundling it with Set.